Fix pathc collision entry lookups#2
Open
IvanKarpan wants to merge 1 commit intoLukeFZ:masterfrom
Open
Conversation
Normalize leading slashes before resolving PATHC collision entries so partial DDS files continue to extract when the collision table stores absolute paths.
IvanKarpan
force-pushed
the
feat/pathc-collision-lookup
branch
from
9e43ef1 to
0bc7b8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After 1.03.00 landed I've noticed issues unpacking 0012, 0015, and 0016. Then stopped trying and started debugging
pycrimsonto figure out what's wrong.This normalizes leading slashes before resolving PATHC collision entries so partial DDS files continue to extract when the collision table stores absolute paths.